Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper does not follow the material guidelines. #7260

Closed
Ploppy3 opened this issue Sep 22, 2017 · 14 comments · Fixed by #7279 or #7479
Closed

Stepper does not follow the material guidelines. #7260

Ploppy3 opened this issue Sep 22, 2017 · 14 comments · Fixed by #7279 or #7479
Assignees

Comments

@Ploppy3
Copy link

Ploppy3 commented Sep 22, 2017

Bug, feature request, or proposal:

Request

What is the expected behavior?

Stepper should follow the material guidelines.
image

What is the current behavior?

Stepper does not follow the material guidelines.
image

What is the use-case or motivation for changing an existing behavior?

Stepper should follow the material guidelines.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

2.0.0-beta.11

Is there anything else we should know?

https://material.io/guidelines/components/steppers.html

  • Grey background is on hover only (currently active steps have grey backgroud?)
  • Grey ripple on click (currently there is no ripple)
  • Steps' labels default color is 87% black (currently unfocused labels are 38% black which means 'disabled text' according to material guidelines)
  • Focused steps' labels should be bold according to images (which helps differentiate active steps from focused steps)
  • Cursor on active steps' labels should be set to 'pointer' when hovering (currently it's set to default 'grab' on label)
@willshowell
Copy link
Contributor

Can you be more specific? Which guidelines in particular does it fail to address?

@Ploppy3
Copy link
Author

Ploppy3 commented Sep 22, 2017

Current implementation just seems wrong due to its many errors, that's why I checked the material guidelines.
Edited with 5 issues so far for horizontal linear stepper & horizontal non-linear stepper.
I did not check for vertical stepper and did not check for mobile stepper.

@willshowell
Copy link
Contributor

Thanks. It's hard to "complete" an issue like this without explicit goals to measure against.

@crisbeto crisbeto self-assigned this Sep 24, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 24, 2017
Aligns the stepper appearance closer to the spec by:
* Removing the focused background when focused by mouse. Now it only shows up for programmatic and keyboard focus.
* Adding ripples to the step header.
* Using a slightly heavier font font the active step.
* Using `cursor: pointer` to show that the step is clickable.

Fixes angular#7260.
@Ploppy3
Copy link
Author

Ploppy3 commented Sep 27, 2017

@crisbeto I see that the issue will be closed but I can't find where your fixed the text color [Steps' labels default color is 87% black (currently unfocused labels are 38% black which means 'disabled text' according to material guidelines)]. Did you fixed it? Thank you.

@crisbeto
Copy link
Member

crisbeto commented Sep 28, 2017

@Ploppy3 I didn't change it, because the spec seems to indicate that the inactive steps are supposed to be 38% black:

Inactive steps

14sp Roboto Regular
38% black

Also note steps two and three here:
Stepper

@Ploppy3
Copy link
Author

Ploppy3 commented Sep 28, 2017

38% black means 'disabled text' but you can click on those right? Unless it is a linear stepper.

@crisbeto
Copy link
Member

The way I interpret it is that disabled text is 38%, but that color isn't reserved only for disabled text. Also AFAIK aside from the orientation, the styling of vertical and horizontal steppers is exactly the same.

@Ploppy3
Copy link
Author

Ploppy3 commented Sep 28, 2017

See images bellow:

I'm not talking about horizontal or vertica but linear vs non-linear where the steps must be done in a left-to right order.

(I do admit that the guidelines are quite complex and probably incorrect at some points)

Linear:
Some steps are disabled so their labels are 38% black.
image

Non Linear:
All steps are enabled therefore the labels are 87% black.
image

@Ploppy3
Copy link
Author

Ploppy3 commented Sep 28, 2017

@crisbeto updated my latest comment with a lot more info so I think I should give you another notification :)

crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 29, 2017
Aligns the stepper appearance closer to the spec by:
* Removing the focused background when focused by mouse. Now it only shows up for programmatic and keyboard focus.
* Adding ripples to the step header.
* Using a slightly heavier font font the active step.
* Using `cursor: pointer` to show that the step is clickable.

Fixes angular#7260.
andrewseguin pushed a commit that referenced this issue Sep 29, 2017
Aligns the stepper appearance closer to the spec by:
* Removing the focused background when focused by mouse. Now it only shows up for programmatic and keyboard focus.
* Adding ripples to the step header.
* Using a slightly heavier font font the active step.
* Using `cursor: pointer` to show that the step is clickable.

Fixes #7260.
@Ploppy3
Copy link
Author

Ploppy3 commented Sep 29, 2017

@crisbeto Did you fix the last thing we talked about?

@crisbeto
Copy link
Member

I didn't have time to get around to it, before it got merged @Ploppy3.

@Ploppy3
Copy link
Author

Ploppy3 commented Sep 30, 2017

Should I reopen or open a new issue?

@crisbeto
Copy link
Member

Let's reopen it.

@crisbeto crisbeto reopened this Sep 30, 2017
@crisbeto crisbeto removed the has pr label Sep 30, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 2, 2017
No longer displays steps as disabled in non-linear mode. Previously they would be greyed-out, causing them to look disabled even though they're clickable.

Fixes angular#7260.
@crisbeto crisbeto added the has pr label Oct 2, 2017
@kara kara closed this as completed in #7479 Oct 6, 2017
kara pushed a commit that referenced this issue Oct 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants