-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viewport-ruler): add common window resize handler #7113
Conversation
@crisbeto I'm seeing a screenshot test failure where the select's popup winds up misaligned. (I'm assuming due to a window resize in the test and the fact that |
I see. I don't think that the resize logic belonged in the scroll strategy in the first place, but I can re-add it in the |
9f4a80e
to
0356487
Compare
@mmalerba I've re-added the resize listener for connected overlays. |
0356487
to
98ce9b5
Compare
98ce9b5
to
8d47cf4
Compare
Needs rebase |
8d47cf4
to
3e3d85f
Compare
3e3d85f
to
4cc43f4
Compare
@crisbeto Can you fix the linter error when you get a chance? |
4cc43f4
to
fd0f21f
Compare
Sorted out the linting issue. |
Gah! Another conflict, sorry @crisbeto |
Adds the `change` method to the `ViewportRuler`, allowing for components to hook up to a common window resize handler. BREAKING CHANGE: Previously the `ScrollDispatcher.scrolled` subscription would react both on scroll events and on window resize events. Now it only reacts to scroll events. To react to resize events, subscribe to the `ViewportRuler.change()` stream.
fd0f21f
to
6af4cd8
Compare
Rebased. |
@crisbeto Check out the test failures? Probably rebase problem? |
6af4cd8
to
c9a4f93
Compare
Seems like something that got introduced from master. Fixed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds the
change
method to theViewportRuler
, allowing for components to hook up to a common window resize handler.BREAKING CHANGE: Previously the
ScrollDispatcher.scrolled
subscription would react both on scroll events and on window resize events. Now it only reacts to scroll events. To react to resize events, subscribe to theViewportRuler.change()
stream.This is a re-submit of #7055.