feat(viewport-ruler): add common window resize handler #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 30, 2017
src/cdk/scrolling/viewport-ruler.ts
Outdated
| merge<Event>( | ||
| fromEvent(window, 'resize'), | ||
| fromEvent(window, 'orientationchange') | ||
| ).subscribe(event => this._changed.next(event.type)); |
There was a problem hiding this comment.
Why subscribe and emit instead of exposing this Observable?
src/cdk/scrolling/viewport-ruler.ts
Outdated
| @@ -20,9 +28,22 @@ export class ViewportRuler { | |||
| /** Cached document client rectangle. */ | |||
| private _documentRect?: ClientRect; | |||
|
|
|||
| constructor(scrollDispatcher: ScrollDispatcher) { | |||
| /** Stream of viewport change events. */ | |||
| private _changed = new Subject<string>(); | |||
There was a problem hiding this comment.
Is the difference between resize and orientationchange useful here? If we make it void we can change it to a more robust object later without it being a breaking change
There was a problem hiding this comment.
The intention was to let people react differently depending on the event, but we can always change it if somebody asks for it.
src/cdk/scrolling/viewport-ruler.ts
Outdated
| // Subscribe to scroll and resize events and update the document rectangle on changes. | ||
| scrollDispatcher.scrolled(0, () => this._cacheViewportGeometry()); | ||
| this.change().subscribe(() => this._cacheViewportGeometry()); |
There was a problem hiding this comment.
Need to unsubscribe in ngOnDestroy?
|
Addressed the feedback @jelbourn. |
jelbourn
approved these changes
Aug 31, 2017
crisbeto
force-pushed
the
viewport-ruler-change-event
branch
from
db65d66
to
6b09cb4
Compare
jelbourn
added
the
presubmit failures
|
crisbeto
force-pushed
the
viewport-ruler-change-event
branch
from
6b09cb4
to
2b4871d
Compare
|
Fixed @jelbourn. |
crisbeto
removed
the
presubmit failures
|
@crisbeto looks like prerender CI task is failing |
Adds the `change` method to the `ViewportRuler`, allowing for components to hook up to a common window resize handler. BREAKING CHANGE: Previously the `ScrollDispatcher.scrolled` subscription would react both on scroll events and on window resize events. Now it only reacts to scroll events. To react to resize events, subscribe to the `ViewportRuler.change()` stream.
crisbeto
force-pushed
the
viewport-ruler-change-event
branch
from
2b4871d
to
0748fb4
Compare
|
Sorted out the prerender failure. |
mmalerba
added a commit
that referenced
this pull request
Sep 13, 2017
* Revert "Revert "fix(menu): multiple close events for a single close" (#7036)" This reverts commit dcfe515. * Revert "feat(datepicker): Add Moment.js adapter (#6860)" This reverts commit 9545427. * Revert "fix(menu): multiple close events for a single close (#6961)" This reverts commit 1cccd4b. * Revert "fix(menu): nested trigger staying highlighted after click (#6853)" This reverts commit 04bf3d1. * Revert "feat(viewport-ruler): add common window resize handler (#6680)" This reverts commit 881630f.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
Adds the `change` method to the `ViewportRuler`, allowing for components to hook up to a common window resize handler. BREAKING CHANGE: Previously the `ScrollDispatcher.scrolled` subscription would react both on scroll events and on window resize events. Now it only reacts to scroll events. To react to resize events, subscribe to the `ViewportRuler.change()` stream.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
…lar#7054) * Revert "Revert "fix(menu): multiple close events for a single close" (angular#7036)" This reverts commit dcfe515. * Revert "feat(datepicker): Add Moment.js adapter (angular#6860)" This reverts commit 9545427. * Revert "fix(menu): multiple close events for a single close (angular#6961)" This reverts commit 1cccd4b. * Revert "fix(menu): nested trigger staying highlighted after click (angular#6853)" This reverts commit 04bf3d1. * Revert "feat(viewport-ruler): add common window resize handler (angular#6680)" This reverts commit 881630f.
|
Is this public? And it's listed in beta 11, but I cannot seem to find the |
|
@rolandjitsu it was reverted and reopened #7113. I think that is an oversight in the changelog |
|
@willshowell thanks, I'll keep an eye on that. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
changemethod to theViewportRuler, allowing for components to hook up to a common window resize handler.BREAKING CHANGE: Previously the
ScrollDispatcher.scrolledsubscription would react both on scroll events and on window resize events. Now it only reacts to scroll events. To react to resize events, subscribe to theViewportRuler.change()stream.