fix(menu): nested trigger staying highlighted after click #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
6838/nested-menu-highlight
branch
from
1790cf5
to
d2df024
Compare
kara
approved these changes
Sep 11, 2017
crisbeto
force-pushed
the
6838/nested-menu-highlight
branch
from
d2df024
to
291dbb1
Compare
crisbeto
added
action: merge
|
@crisbeto retried the tests several times and the error seems to be persisting, can you investigate whether its a real failure? |
Prevents the sub-menu trigger from staying highlighted if the user clicks on it and moves away to another menu item. Fixes angular#6838.
crisbeto
force-pushed
the
6838/nested-menu-highlight
branch
from
291dbb1
to
c4a4f84
Compare
|
Turns out it was something in this PR @mmalerba. Fixed. |
mmalerba
added a commit
that referenced
this pull request
Sep 13, 2017
)" This reverts commit 04bf3d1.
mmalerba
added a commit
that referenced
this pull request
Sep 13, 2017
* Revert "Revert "fix(menu): multiple close events for a single close" (#7036)" This reverts commit dcfe515. * Revert "feat(datepicker): Add Moment.js adapter (#6860)" This reverts commit 9545427. * Revert "fix(menu): multiple close events for a single close (#6961)" This reverts commit 1cccd4b. * Revert "fix(menu): nested trigger staying highlighted after click (#6853)" This reverts commit 04bf3d1. * Revert "feat(viewport-ruler): add common window resize handler (#6680)" This reverts commit 881630f.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
* fix(menu): nested trigger staying highlighted after click Prevents the sub-menu trigger from staying highlighted if the user clicks on it and moves away to another menu item. Fixes angular#6838. * fix: firefox tests crashing
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
…lar#7054) * Revert "Revert "fix(menu): multiple close events for a single close" (angular#7036)" This reverts commit dcfe515. * Revert "feat(datepicker): Add Moment.js adapter (angular#6860)" This reverts commit 9545427. * Revert "fix(menu): multiple close events for a single close (angular#6961)" This reverts commit 1cccd4b. * Revert "fix(menu): nested trigger staying highlighted after click (angular#6853)" This reverts commit 04bf3d1. * Revert "feat(viewport-ruler): add common window resize handler (angular#6680)" This reverts commit 881630f.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the sub-menu trigger from staying highlighted if the user clicks on it and moves away to another menu item.
Fixes #6838.