fix(button-toggle): border radius ignored if option is selected #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Material Design specifications, the button-toggle group should always have a border radius. This behavior has been implemented in the `md-button-toggle-group` component, but does not work properly if an option is selected or disabled. This happens because selected and disabled button-toggles receives a background color, which overflows the clipped button-toggle-group. Fixes angular#6689
googlebot
added
the
cla: yes
tinayuangao
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Material Design specifications, the button-toggle group should always have a border radius.
This behavior has been implemented in the
md-button-toggle-groupcomponent, but does not work properly if an option is selected or disabled.This happens because selected and disabled button-toggles receives a background color, which overflows the clipped button-toggle-group.
Fixes #6689