Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outer md-button-toggle within md-button-toggle-group do not have round corners when selected or disabled #6689

Closed
MA-Maddin opened this issue Aug 29, 2017 · 4 comments · Fixed by #6699
Assignees

Comments

@MA-Maddin
Copy link
Contributor

MA-Maddin commented Aug 29, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Proper styling (round corners) of md-button-toggle within md-button-toggle-group

good

What is the current behavior?

Outer buttons do not have round corners when selected or disabled

wrong

What are the steps to reproduce?

https://material.angular.io/components/button-toggle/examples

What is the use-case or motivation for changing an existing behavior?

Comply with Material Design specs

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 2.0.0-beta.8
Google Chrome Version 60.0.3112.113 (Offizieller Build) (64-Bit)
Firefox 55.0.3 (64-Bit)

Is there anything else we should know?

This fixes the styling:

.mat-button-toggle:first-child.mat-button-toggle-checked, .mat-button-toggle:first-child.mat-button-toggle-disabled {
    border-top-left-radius: inherit;
    border-bottom-left-radius: inherit;
}
.mat-button-toggle:last-child.mat-button-toggle-checked, .mat-button-toggle:last-child.mat-button-toggle-disabled {
    border-top-right-radius: inherit;
    border-bottom-right-radius: inherit;
}
@devversion
Copy link
Member

Where is that picture from? When looking at the Material Design specs the button-toggle is described differently.

@MA-Maddin
Copy link
Contributor Author

MA-Maddin commented Aug 29, 2017

I made this screenshot from the docs example page https://material.angular.io/components/button-toggle/examples . I just set a dark background color to highlight the issue.

But what is different in my expected behavior to MD specs?

Found a better fix for that issue:

.mat-button-toggle-group {
    overflow: hidden;
}

@devversion
Copy link
Member

@MA-Maddin Nothing, you're right. Your initial screenshot just looked like a screenshot from the specs to me.

@devversion devversion self-assigned this Aug 29, 2017
devversion added a commit to devversion/material2 that referenced this issue Aug 29, 2017
As per Material Design specifications, the button-toggle group should always have a border radius.

This behavior has been implemented in the `md-button-toggle-group` component, but does not work properly if an option is selected or disabled. This happens because selected and disabled button-toggles receives a background color, which overflows the clipped button-toggle-group.

Fixes angular#6689
jelbourn pushed a commit that referenced this issue Aug 30, 2017
As per Material Design specifications, the button-toggle group should always have a border radius.

This behavior has been implemented in the `md-button-toggle-group` component, but does not work properly if an option is selected or disabled. This happens because selected and disabled button-toggles receives a background color, which overflows the clipped button-toggle-group.

Fixes #6689
jelbourn pushed a commit that referenced this issue Sep 1, 2017
As per Material Design specifications, the button-toggle group should always have a border radius.

This behavior has been implemented in the `md-button-toggle-group` component, but does not work properly if an option is selected or disabled. This happens because selected and disabled button-toggles receives a background color, which overflows the clipped button-toggle-group.

Fixes #6689
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants