-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
md-dialog-close should also have an input for mdDialogClose #6278
Comments
…se selectors Fixes not being able to pass in a dialog result through the `mdDialogClose`, `matDialogClose` and `mat-dialog-close` selectors, even though they are allowed by the `MdDialogClose` directive. Fixes angular#6278.
…se selectors Fixes not being able to pass in a dialog result through the `mdDialogClose`, `matDialogClose` and `mat-dialog-close` selectors, even though they are allowed by the `MdDialogClose` directive. Fixes #6278.
Try to save the initial value when the dialog is open so you can return if you press close. ngOnInit() {
} submit(form) { close() { |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Request
What is the expected behavior?
Using the dialog close directive should allow the following syntax
What is the current behavior?
Angular complains it can't bind to
mdDialogClose
since it isn't listed as a valid inputWhat are the steps to reproduce?
https://plnkr.co/edit/m7e7vFIKKgTiWIwCY7pc?p=preview
What is the use-case or motivation for changing an existing behavior?
I've noticed that across the library, components use kebab-case and directives use camelCase (but also allow kebab-case) for their selectors. I'd like to keep this consistent within my application, but I can't because while
[mdDialogClose]
is a valid selector, I can't bind a value to it.Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest
The text was updated successfully, but these errors were encountered: