Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): support passing in dialog result through all MdDialogClose selectors #6293

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 5, 2017

Fixes not being able to pass in a dialog result through the mdDialogClose, matDialogClose and mat-dialog-close selectors, even though they are allowed by the MdDialogClose directive.

Fixes #6278.

…se selectors

Fixes not being able to pass in a dialog result through the `mdDialogClose`, `matDialogClose` and `mat-dialog-close` selectors, even though they are allowed by the `MdDialogClose` directive.

Fixes angular#6278.
@crisbeto crisbeto requested a review from jelbourn as a code owner August 5, 2017 15:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 7, 2017
@mmalerba mmalerba merged commit 4a1f10e into angular:master Aug 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-dialog-close should also have an input for mdDialogClose
4 participants