Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename cdk/keyboard -> keycodes & cdk/observe-content -> observers #6039

Merged
merged 1 commit into from
Aug 9, 2017
Merged

feat: rename cdk/keyboard -> keycodes & cdk/observe-content -> observers #6039

merged 1 commit into from
Aug 9, 2017

Conversation

jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2017
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker pr: lgtm and removed pr: needs review labels Jul 28, 2017
@jelbourn jelbourn mentioned this pull request Jul 28, 2017
Merged
@tinayuangao
Copy link
Contributor

@jelbourn please rebase. Thanks!

@jelbourn
Copy link
Member Author

@tinayuangao rebased

@mmalerba mmalerba added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Aug 7, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Aug 7, 2017

please rebase

@jelbourn
Copy link
Member Author

jelbourn commented Aug 7, 2017

@mmalerba Rebased

crisbeto
crisbeto approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: oh, from two weeks ago. Seems like the rebase added me as a reviewer.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: needs rebase and removed pr: needs rebase action: merge The PR is ready for merge by the caretaker labels Aug 7, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Aug 8, 2017

needs rebase

@jelbourn
Copy link
Member Author

jelbourn commented Aug 8, 2017

@mmalerba rebased

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 8, 2017
@mmalerba mmalerba merged commit 9df292f into angular:master Aug 9, 2017
@grizzm0 grizzm0 mentioned this pull request Aug 9, 2017
Closed
@jelbourn jelbourn deleted the cdk-renames branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jelbourn @tinayuangao @mmalerba @crisbeto @googlebot @andrewseguin