Skip to content

Commit

Permalink
feat: rename cdk/keyboard -> keycodes & cdk/observe-content -> observers
Browse files Browse the repository at this point in the history
  • Loading branch information
jelbourn committed Jul 28, 2017
1 parent cf071c7 commit ec264e6
Show file tree
Hide file tree
Showing 25 changed files with 37 additions and 36 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ lib/core/datetime/** @mmalerba
# CDK
cdk/coercion/** @jelbourn
cdk/rxjs/** @jelbourn
cdk/observe-content/** @crisbeto @jelbourn
cdk/observers/** @crisbeto @jelbourn
cdk/a11y/** @jelbourn @devversion
cdk/platform/** @jelbourn @devversion
cdk/bidi/** @jelbourn
Expand Down
6 changes: 3 additions & 3 deletions scripts/closure-compiler/build-devapp-bundle.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ OPTS=(
"--js_module_root=dist/releases/cdk/a11y"
"--js_module_root=dist/releases/cdk/bidi"
"--js_module_root=dist/releases/cdk/coercion"
"--js_module_root=dist/releases/cdk/keyboard"
"--js_module_root=dist/releases/cdk/observe-content"
"--js_module_root=dist/releases/cdk/keycodes"
"--js_module_root=dist/releases/cdk/observers"
"--js_module_root=dist/releases/cdk/platform"
"--js_module_root=dist/releases/cdk/portal"
"--js_module_root=dist/releases/cdk/rxjs"
Expand All @@ -74,7 +74,7 @@ OPTS=(
dist/releases/cdk/@angular/cdk/a11y.js
dist/releases/cdk/@angular/cdk/bidi.js
dist/releases/cdk/@angular/cdk/coercion.js
dist/releases/cdk/@angular/cdk/keyboard.js
dist/releases/cdk/@angular/cdk/keycodes.js
dist/releases/cdk/@angular/cdk/observe-content.js
dist/releases/cdk/@angular/cdk/platform.js
dist/releases/cdk/@angular/cdk/portal.js
Expand Down
2 changes: 1 addition & 1 deletion src/cdk/a11y/list-key-manager.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {QueryList} from '@angular/core';
import {fakeAsync, tick} from '@angular/core/testing';
import {FocusKeyManager} from './focus-key-manager';
import {DOWN_ARROW, UP_ARROW, TAB} from '../keyboard/keycodes';
import {DOWN_ARROW, UP_ARROW, TAB} from '../keycodes/keycodes';
import {ListKeyManager} from './list-key-manager';
import {ActiveDescendantKeyManager} from './activedescendant-key-manager';
import {createKeyboardEvent} from '../testing/event-objects';
Expand Down
3 changes: 2 additions & 1 deletion src/cdk/a11y/list-key-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
import {QueryList} from '@angular/core';
import {Observable} from 'rxjs/Observable';
import {Subject} from 'rxjs/Subject';
import {UP_ARROW, DOWN_ARROW, TAB} from '@angular/cdk/keyboard';
import {UP_ARROW, DOWN_ARROW, TAB} from '@angular/cdk/keycodes';


/**
* This interface is for items that can be disabled. The type passed into
Expand Down
2 changes: 1 addition & 1 deletion src/cdk/a11y/tsconfig-build.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"baseUrl": ".",
"paths": {
"@angular/cdk/coercion": ["../../../dist/packages/cdk/coercion/public_api"],
"@angular/cdk/keyboard": ["../../../dist/packages/cdk/keyboard/public_api"],
"@angular/cdk/keycodes": ["../../../dist/packages/cdk/keycodes/public_api"],
"@angular/cdk/platform": ["../../../dist/packages/cdk/platform/public_api"],
"@angular/cdk/rxjs": ["../../../dist/packages/cdk/rxjs/public_api"]
}
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"annotateForClosureCompiler": true,
"strictMetadataEmit": true,
"flatModuleOutFile": "index.js",
"flatModuleId": "@angular/cdk/keyboard",
"flatModuleId": "@angular/cdk/keycodes",
"skipTemplateCodegen": true
}
}
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {Component} from '@angular/core';
import {async, TestBed, ComponentFixture, fakeAsync, tick} from '@angular/core/testing';
import {ObserveContentModule, MdMutationObserverFactory} from './observe-content';
import {ObserversModule, MdMutationObserverFactory} from './observe-content';

// TODO(elad): `ProxyZone` doesn't seem to capture the events raised by
// `MutationObserver` and needs to be investigated
Expand All @@ -9,7 +9,7 @@ describe('Observe content', () => {
describe('basic usage', () => {
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [ObserveContentModule],
imports: [ObserversModule],
declarations: [ComponentWithTextContent, ComponentWithChildTextContent]
});

Expand Down Expand Up @@ -58,7 +58,7 @@ describe('Observe content', () => {
callbacks = [];

TestBed.configureTestingModule({
imports: [ObserveContentModule],
imports: [ObserversModule],
declarations: [ComponentWithDebouncedListener],
providers: [{
provide: MdMutationObserverFactory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,4 @@ export class ObserveContent implements AfterContentInit, OnDestroy {
declarations: [ObserveContent],
providers: [MdMutationObserverFactory]
})
export class ObserveContentModule {}
export class ObserversModule {}
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"annotateForClosureCompiler": true,
"strictMetadataEmit": true,
"flatModuleOutFile": "index.js",
"flatModuleId": "@angular/cdk/observe-content",
"flatModuleId": "@angular/cdk/observers",
"skipTemplateCodegen": true
}
}
4 changes: 2 additions & 2 deletions src/demo-app/system-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ System.config({
'@angular/cdk/a11y': 'dist/bundles/cdk-a11y.umd.js',
'@angular/cdk/bidi': 'dist/bundles/cdk-bidi.umd.js',
'@angular/cdk/coercion': 'dist/bundles/cdk-coercion.umd.js',
'@angular/cdk/keyboard': 'dist/bundles/cdk-keyboard.umd.js',
'@angular/cdk/observe-content': 'dist/bundles/cdk-observe-content.umd.js',
'@angular/cdk/keycodes': 'dist/bundles/cdk-keycodes.umd.js',
'@angular/cdk/observers': 'dist/bundles/cdk-observers.umd.js',
'@angular/cdk/platform': 'dist/bundles/cdk-platform.umd.js',
'@angular/cdk/portal': 'dist/bundles/cdk-portal.umd.js',
'@angular/cdk/rxjs': 'dist/bundles/cdk-rxjs.umd.js',
Expand Down
4 changes: 2 additions & 2 deletions src/e2e-app/system-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ System.config({
'@angular/cdk/a11y': 'dist/bundles/cdk-a11y.umd.js',
'@angular/cdk/bidi': 'dist/bundles/cdk-bidi.umd.js',
'@angular/cdk/coercion': 'dist/bundles/cdk-coercion.umd.js',
'@angular/cdk/keyboard': 'dist/bundles/cdk-keyboard.umd.js',
'@angular/cdk/observe-content': 'dist/bundles/cdk-observe-content.umd.js',
'@angular/cdk/keycodes': 'dist/bundles/cdk-keycodes.umd.js',
'@angular/cdk/observers': 'dist/bundles/cdk-observers.umd.js',
'@angular/cdk/platform': 'dist/bundles/cdk-platform.umd.js',
'@angular/cdk/portal': 'dist/bundles/cdk-portal.umd.js',
'@angular/cdk/rxjs': 'dist/bundles/cdk-rxjs.umd.js',
Expand Down
4 changes: 2 additions & 2 deletions src/lib/checkbox/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@

import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {ObserveContentModule} from '@angular/cdk/observe-content';
import {ObserversModule} from '@angular/cdk/observers';
import {MdRippleModule, MdCommonModule, FocusOriginMonitor} from '../core';
import {MdCheckbox} from './checkbox';
import {MdCheckboxRequiredValidator} from './checkbox-required-validator';

@NgModule({
imports: [CommonModule, MdRippleModule, MdCommonModule, ObserveContentModule],
imports: [CommonModule, MdRippleModule, MdCommonModule, ObserversModule],
exports: [MdCheckbox, MdCheckboxRequiredValidator, MdCommonModule],
declarations: [MdCheckbox, MdCheckboxRequiredValidator],
providers: [FocusOriginMonitor]
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/common-behaviors/common-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

import {NgModule, InjectionToken, Optional, Inject, isDevMode} from '@angular/core';
import {DOCUMENT} from '@angular/platform-browser';
import {BidiModule} from '@angular/cdk/bidi';
import {CompatibilityModule} from '../compatibility/compatibility';
import {BidiModule} from '../bidi/index';


/** Injection token that configures whether the Material sanity checks are enabled. */
Expand Down
10 changes: 5 additions & 5 deletions src/lib/core/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import {NgModule} from '@angular/core';
import {ObserveContentModule} from '@angular/cdk/observe-content';
import {ObserversModule} from '@angular/cdk/observers';
import {MdLineModule} from './line/line';
import {BidiModule} from './bidi/index';
import {MdOptionModule} from './option/index';
Expand All @@ -24,9 +24,9 @@ export {
} from '@angular/cdk/coercion';

export {
ObserveContentModule,
ObserversModule,
ObserveContent,
} from '@angular/cdk/observe-content';
} from '@angular/cdk/observers';

// RTL
export {Dir, Direction, Directionality, BidiModule} from './bidi/index';
Expand Down Expand Up @@ -135,7 +135,7 @@ export {
MdLineModule,
BidiModule,
MdRippleModule,
ObserveContentModule,
ObserversModule,
PortalModule,
OverlayModule,
A11yModule,
Expand All @@ -146,7 +146,7 @@ export {
MdLineModule,
BidiModule,
MdRippleModule,
ObserveContentModule,
ObserversModule,
PortalModule,
OverlayModule,
A11yModule,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/core/keyboard/keycodes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ export {
ESCAPE,
BACKSPACE,
DELETE
} from '@angular/cdk/keyboard';
} from '@angular/cdk/keycodes';
4 changes: 2 additions & 2 deletions src/lib/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
BidiModule,
MdCommonModule,
MdRippleModule,
ObserveContentModule,
ObserversModule,
OverlayModule,
PortalModule
} from './core/index';
Expand Down Expand Up @@ -86,7 +86,7 @@ const MATERIAL_MODULES = [
A11yModule,
PlatformModule,
MdCommonModule,
ObserveContentModule
ObserversModule
];

/** @deprecated */
Expand Down
4 changes: 2 additions & 2 deletions src/lib/tabs/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import {NgModule} from '@angular/core';
import {CommonModule} from '@angular/common';
import {MdCommonModule} from '../core';
import {ObserveContentModule} from '@angular/cdk/observe-content';
import {ObserversModule} from '@angular/cdk/observers';
import {PortalModule} from '../core';
import {MdRippleModule} from '../core/ripple/index';
import {MdTab} from './tab';
Expand All @@ -30,7 +30,7 @@ import {ScrollDispatchModule} from '../core/overlay/scroll/index';
MdCommonModule,
PortalModule,
MdRippleModule,
ObserveContentModule,
ObserversModule,
ScrollDispatchModule,
],
// Don't export all components because some are only to be used internally.
Expand Down
4 changes: 2 additions & 2 deletions test/karma-test-shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ System.config({
'@angular/cdk/a11y': 'dist/packages/cdk/a11y/index.js',
'@angular/cdk/bidi': 'dist/packages/cdk/bidi/index.js',
'@angular/cdk/coercion': 'dist/packages/cdk/coercion/index.js',
'@angular/cdk/keyboard': 'dist/packages/cdk/keyboard/index.js',
'@angular/cdk/observe-content': 'dist/packages/cdk/observe-content/index.js',
'@angular/cdk/keycodes': 'dist/packages/cdk/keycodes/index.js',
'@angular/cdk/observers': 'dist/packages/cdk/observers/index.js',
'@angular/cdk/platform': 'dist/packages/cdk/platform/index.js',
'@angular/cdk/portal': 'dist/packages/cdk/portal/index.js',
'@angular/cdk/rxjs': 'dist/packages/cdk/rxjs/index.js',
Expand Down
4 changes: 2 additions & 2 deletions tools/package-tools/rollup-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const ROLLUP_GLOBALS = {
'@angular/cdk/a11y': 'ng.cdk.a11y',
'@angular/cdk/bidi': 'ng.cdk.bidi',
'@angular/cdk/coercion': 'ng.cdk.coercion',
'@angular/cdk/keyboard': 'ng.cdk.keyboard',
'@angular/cdk/observe-content': 'ng.cdk.observeContent',
'@angular/cdk/keycodes': 'ng.cdk.keycodes',
'@angular/cdk/observers': 'ng.cdk.observers',
'@angular/cdk/platform': 'ng.cdk.platform',
'@angular/cdk/portal': 'ng.cdk.portal',
'@angular/cdk/rxjs': 'ng.cdk.rxjs',
Expand Down
4 changes: 2 additions & 2 deletions tools/package-tools/secondary-entry-points.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
const CDK_ENTRY_POINTS = [
'coercion',
'rxjs',
'keyboard',
'keycodes',
'platform',
'bidi',
'table',
'portal',
'observe-content',
'observers',
'a11y',
];

Expand Down

0 comments on commit ec264e6

Please sign in to comment.