Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): not updating the size while the panel is open #4346

Merged
merged 1 commit into from
May 9, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 1, 2017

Fixes the autocomplete panel not being resized while it is open. It was due to it recalculating the width, but not calling overlayRef.updateSize.

Fixes #4146.

Fixes the autocomplete panel not being resized while it is open. It was due to it recalculating the width, but not calling `overlayRef.updateSize`.

Fixes angular#4146.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 1, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment May 5, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 5, 2017
@kara kara merged commit bfeb515 into angular:master May 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request, Autocomplete: Defer calculation of width until actually showing dropdown
3 participants