Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): not updating the size while the panel is open #4346

Merged
merged 1 commit into from
May 9, 2017
Merged

fix(autocomplete): not updating the size while the panel is open #4346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/autocomplete/autocomplete-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ export class MdAutocompleteTrigger implements ControlValueAccessor, OnDestroy {
} else {
/** Update the panel width, in case the host width has changed */
this._overlayRef.getState().width = this._getHostWidth();
this._overlayRef.updateSize();
}

if (!this._overlayRef.hasAttached()) {
Expand Down
27 changes: 25 additions & 2 deletions src/lib/autocomplete/autocomplete.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ describe('MdAutocomplete', () => {

const overlayPane = overlayContainerElement.querySelector('.cdk-overlay-pane') as HTMLElement;
// Firefox, edge return a decimal value for width, so we need to parse and round it to verify
expect(Math.ceil(parseFloat(overlayPane.style.width))).toEqual(300);
expect(Math.ceil(parseFloat(overlayPane.style.width))).toBe(300);

widthFixture.componentInstance.trigger.closePanel();
widthFixture.detectChanges();
Expand All @@ -1158,8 +1158,31 @@ describe('MdAutocomplete', () => {
widthFixture.detectChanges();

// Firefox, edge return a decimal value for width, so we need to parse and round it to verify
expect(Math.ceil(parseFloat(overlayPane.style.width))).toEqual(500);
expect(Math.ceil(parseFloat(overlayPane.style.width))).toBe(500);
});

it('should update the width while the panel is open', () => {
const widthFixture = TestBed.createComponent(SimpleAutocomplete);

widthFixture.componentInstance.width = 300;
widthFixture.detectChanges();

widthFixture.componentInstance.trigger.openPanel();
widthFixture.detectChanges();

const overlayPane = overlayContainerElement.querySelector('.cdk-overlay-pane') as HTMLElement;
const input = widthFixture.debugElement.query(By.css('input')).nativeElement;

expect(Math.ceil(parseFloat(overlayPane.style.width))).toBe(300);

widthFixture.componentInstance.width = 500;
widthFixture.detectChanges();

input.focus();
dispatchFakeEvent(input, 'input');
widthFixture.detectChanges();

expect(Math.ceil(parseFloat(overlayPane.style.width))).toBe(500);
});

it('should show the panel when the options are initialized later within a component with ' +
Expand Down