Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-select has no color parameter #3923

Closed
mariuspruski opened this issue Apr 6, 2017 · 1 comment · Fixed by #3928
Closed

md-select has no color parameter #3923

mariuspruski opened this issue Apr 6, 2017 · 1 comment · Fixed by #3928
Assignees
@crisbeto

Comments

@mariuspruski
Copy link

Bug, feature request, or proposal:

Feature request.

What is the expected behavior?

It's possible with md-input-containers to specify the dividerColor (accent, primary, warn). I would have expected md-select to have an equivalent property.

What is the current behavior?

I could not locate any such property. I ended up overwriting the theming of the md-select component myself just to change it from 'primary' to 'accent' color.

What are the steps to reproduce?

--

Which versions of Angular, Material, OS, browsers are affected?

I'm on Angular Material 2.0.0-beta.2.
@crisbeto crisbeto self-assigned this Apr 6, 2017
@crisbeto crisbeto added the has pr label Apr 6, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 6, 2017
@crisbeto
feat(select): allow setting the theme color
9f67962 
* Allows the user to set the theme color of a `md-select`.
* Adds theming to the `md-option` component.
* Tweaks the `md-pseudo-checkbox` theme to allow it to inherit the color.

Fixes angular#3923.
@crisbeto crisbeto mentioned this issue Apr 6, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 8, 2017
@crisbeto
feat(select): allow setting the theme color
3bbdd97 
* Allows the user to set the theme color of a `md-select`.
* Adds theming to the `md-option` component.
* Tweaks the `md-pseudo-checkbox` theme to allow it to inherit the color.

Fixes angular#3923.
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 17, 2017
@crisbeto
feat(select): allow setting the theme color
d299c84 
* Allows the user to set the theme color of a `md-select`.
* Adds theming to the `md-option` component.
* Tweaks the `md-pseudo-checkbox` theme to allow it to inherit the color.

Fixes angular#3923.
kara pushed a commit that referenced this issue Apr 21, 2017
@crisbeto @kara
feat(select): allow setting the theme color (#3928)
3a29d67 
Fixes #3923.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(select): allow setting the theme color crisbeto/material2
2 participants
@crisbeto @mariuspruski