feat(select): allow setting the theme color #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
3923/select-theme
branch
from
9f67962
to
3bbdd97
Compare
jelbourn
reviewed
Apr 14, 2017
| @@ -24,15 +24,15 @@ | |||
| } | |||
|
|
|||
| .mat-pseudo-checkbox-checked, .mat-pseudo-checkbox-indeterminate { | |||
| &.mat-primary { | |||
| &.mat-primary, .mat-primary & { | |||
There was a problem hiding this comment.
As we discovered in #4077, adding the & of the selector doesn't work with secondary themes
src/lib/select/_select-theme.scss
Outdated
|
|
||
| .mat-select-underline { | ||
| background-color: mat-color($primary); | ||
| } |
* Allows the user to set the theme color of a `md-select`. * Adds theming to the `md-option` component. * Tweaks the `md-pseudo-checkbox` theme to allow it to inherit the color. Fixes angular#3923.
crisbeto
force-pushed
the
3923/select-theme
branch
from
3bbdd97
to
d299c84
Compare
|
Addressed the feedback, rebased and cleaned up the select theming in general. Can you take another look @jelbourn? |
|
Fixed the theming on the options @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 18, 2017
* Fixes certain theme selectors being broken due to uses of the `&` operator at the end of the selector. * Adds a custom Stylelint rule to catch future improper uses of the ampersand inside themes. Relates to angular#3928. Fixes angular#4077.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 21, 2017
* Fixes certain theme selectors being broken due to uses of the `&` operator at the end of the selector. * Adds a custom Stylelint rule to catch future improper uses of the ampersand inside themes. Relates to angular#3928. Fixes angular#4077.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-select.md-optioncomponent.md-pseudo-checkboxtheme to allow it to inherit the color.Fixes #3923.