-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to @angular 2.0.0-rc0 packages and latest CLI #384
Conversation
}); | ||
it('should emit a change event when the `checked` value changes', () => { | ||
// TODO(jelbourn): this *should* work with fakeAsync, but there seems to be a bug. | ||
// As a short-term soltution, use a promise (which jasmine knows how to understand). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: soltution -> solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Left a few nitpicky comments about consolidating imports, typos, etc. But looks good to me otherwise. |
}, | ||
'@angular/core': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: we could probably build this object with a function and an array of bundle names to save the copy-pasting. But probably outside the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation, done.
@hansl Going to wait for new CLI version on top of new packages before submitting this. |
Also going to |
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular#9648
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In-progress PR to run CI tests w/ new world.
Also I rewrote all of the checkbox tests to be dramatically cleaner.