Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @angular 2.0.0-rc0 packages and latest CLI #384

Merged
merged 5 commits into from
May 4, 2016

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented May 2, 2016

In-progress PR to run CI tests w/ new world.

Also I rewrote all of the checkbox tests to be dramatically cleaner.

@jelbourn jelbourn added the in progress This issue is currently in progress label May 2, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 2, 2016
@jelbourn jelbourn changed the title WIP: new world WIP: new world 0.0.0-4 May 2, 2016
@jelbourn jelbourn changed the title WIP: new world 0.0.0-4 WIP: new world latest May 2, 2016
});
it('should emit a change event when the `checked` value changes', () => {
// TODO(jelbourn): this *should* work with fakeAsync, but there seems to be a bug.
// As a short-term soltution, use a promise (which jasmine knows how to understand).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: soltution -> solution

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kara
Copy link
Contributor

kara commented May 2, 2016

Left a few nitpicky comments about consolidating imports, typos, etc. But looks good to me otherwise.

},
'@angular/core': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: we could probably build this object with a function and an array of bundle names to save the copy-pasting. But probably outside the scope of this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation, done.

@jelbourn
Copy link
Member Author

jelbourn commented May 3, 2016

@hansl Going to wait for new CLI version on top of new packages before submitting this.

@jelbourn
Copy link
Member Author

jelbourn commented May 3, 2016

Also going to 2.0.0-rc.0 involved updating the router, which was a very simple change.

@jelbourn jelbourn deleted the newest-packages branch May 19, 2016 16:56
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion.
* Fixes that the deprecation markers are too big and are not looking good in the API table
* Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good.

References angular#9648
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement in progress This issue is currently in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants