This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): only handle results if it's an array or a promise #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the autocomplete will handle the results wrong. So if we specify for example an empty JSON-Object, the autocomplete will handle the results as an async promise. Fixes angular#7074
|
LGTM |
EladBezalel
added
pr: merge ready
| if ( isList ) handleResults(items); | ||
| else handleAsyncResults(items); | ||
| if (isList) handleResults(items); | ||
| else if (isPromise) handleAsyncResults(items); |
There was a problem hiding this comment.
Messing scenario: what if not a list and not a Promise?
There was a problem hiding this comment.
I thought about doing nothing, because it makes no sense, and otherwise it will prevent the autocomplete from working. See the demo of the actual issue. http://codepen.io/anon/pen/Gowjmv?editors=1010
gmoothart
pushed a commit
to gmoothart/material
that referenced
this pull request
Apr 5, 2016
At the moment the autocomplete will handle the results wrong. So if we specify for example an empty JSON-Object, the autocomplete will handle the results as an async promise. Fixes angular#7074 Closes angular#7089
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the autocomplete will handle the results wrong.
So if we specify for example an empty JSON-Object, the autocomplete will handle the results as an async promise.
Fixes #7074