Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(docs): menu toggle is not open on the current page #6572

Closed
wants to merge 2 commits into from
Closed

fix(docs): menu toggle is not open on the current page #6572

wants to merge 2 commits into from

Conversation

8lueberry
Copy link
Contributor

Fix docs nav toggle to open the current page when refreshing the page or navigating directly to a section.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@8lueberry
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@8lueberry
Copy link
Contributor Author

Bug description: When navigating to https://material.angularjs.org/latest/demo/whiteframe for example, the menu is not selected on the left (the toggle icon is correct, but the sub menu is not shown).

Wrapped getTargetHeight() in a $timeout in order to get the proper ul height (instead of 0).

@8lueberry 8lueberry changed the title Doc page, the menu toggle is not open on the current page fix(docs): menu toggle is not open on the current page Jan 8, 2016
@ThomasBurleson ThomasBurleson added the pr: merge ready This PR is ready for a caretaker to review label Jan 28, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.4 milestone Jan 28, 2016
@ThomasBurleson ThomasBurleson self-assigned this Jan 28, 2016
devversion added a commit to devversion/material that referenced this pull request Jan 31, 2016
ThomasBurleson pushed a commit that referenced this pull request Feb 1, 2016
ThomasBurleson pushed a commit that referenced this pull request Feb 1, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants