fix(autocomplete): fix progressbar and messages alignment and bottom padding #6258
Conversation
…padding. - There was too much padding at the bottom (padding already done by the input container) - Progressbar was wrong aligned due wrong bottom padding (as above said) Fixes angular#6218 Closes angular#6231 Fixes angular#6255
devversion
force-pushed
the
fix/autocomplete-padding-bottom
branch
from
d4c91ff
to
adc948f
Compare
|
you need to fix the offset of the progress bar as well since it takes the padding into account see https://github.com/angular/material/blob/master/src/components/autocomplete/autocomplete.scss#L89 |
|
The padding is already added by the Input Container Little preview for you: |
|
Works perfectly for me @devversion ! |
|
Thanks for checking it out :) |
|
I had a fix going for #5672 so that messed it up sorry ^^ |
ThomasBurleson
added
pr: merge ready
| &.md-input-has-messages { | ||
| padding-bottom: $input-container-padding; | ||
| } | ||
| padding-bottom: 0px; |
There was a problem hiding this comment.
I think this should be padding-bottom: $input-container-padding so that it is bottom-aligned with the input. Based on the GIF you provided, it looks like the progress bar sits above the input's bottom border which is incorrect.
There was a problem hiding this comment.
Nope; don't listen to me...apparently that bumps the progress bar below the autocomplete.
Fixes #6218 Closes #6231 Fixes #6255