This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
WIP: fix(toast): sanitize auto wrapped custom toast templates #11652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There was an issue filed in g3 about using innerHTML here in
md-toast
for custom toasts.Issue Number:
Related to #6494. Related to #6259.
What is the new behavior?
Protect against a possible XSS vector by sanitizing all elements inside of the template's outer
<md-toast><sanitize everything here></md-toast>
element. This could be multiple DOM elements, comments, etc.Does this PR introduce a breaking change?
This may require
ngSanitize
in some apps that previously didn't use it. In those cases, the apps would break with an$sce
exception.Other information
This uses a similar approach to md-select's approach to sanitizing text that can contain HTML.