Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

MenuController.js - unregisters "handleMenuItemMouseLeave" handler incorrectly #7947

Closed
ChrisNightingale opened this issue Apr 8, 2016 · 0 comments
Closed

MenuController.js - unregisters "handleMenuItemMouseLeave" handler incorrectly #7947

ChrisNightingale opened this issue Apr 8, 2016 · 0 comments

Comments

@ChrisNightingale
Copy link

Hi all,

I hope I have specified this correctly as I'm pretty new to all this Angular stuff (and web dev in general) but I have been playing around with the MenuController in an attempt to create a context menu (which I know is a whole other issue!! https://github.com/angular/material/issues/3493).

While messing around with the code I noticed that in the disableHoverListener function it tries to unregister 2 event handlers:

  • handleMenuItemHover
  • handleMenuMouseLeave

except that "handleMenuMouseLeave" should be "handleMenuItemMouseLeave" (see function enableHoverListener for the corresponding handler registrations which are correct)
topherfangio added a commit to profoundry-us/material that referenced this issue Apr 14, 2016
@topherfangio
fix(menu): Typo in hover deregistration.
29fac2b 
There was a typo in the hover deregistration code which attempted
to deregister an non-existent function. Fix by adding `Item` to
the handler.

Fixes angular#7947.
@topherfangio topherfangio mentioned this issue Apr 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisNightingale