Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

theming dark default background md-hue-3 is an not a valid hue #7600

Closed
ilovett opened this issue Mar 16, 2016 · 2 comments
Closed

theming dark default background md-hue-3 is an not a valid hue #7600

ilovett opened this issue Mar 16, 2016 · 2 comments
Assignees
Labels
P0: critical Critical issues that must be addressed immediately. type: bug

Comments

@ilovett
Copy link
Contributor

ilovett commented Mar 16, 2016

Value is '1000' but is not listed in

var VALID_HUE_VALUES = [
  '50', '100', '200', '300', '400', '500', '600',
  '700', '800', '900', 'A100', 'A200', 'A400', 'A700'
];
@topherfangio topherfangio added type: bug P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Mar 16, 2016
@EladBezalel
Copy link
Member

I think i wanted absolute black which defined here

@ilovett
Copy link
Contributor Author

ilovett commented Mar 17, 2016

Also, when defining backgroundPalette('myCustomPalette').dark() ngMaterial will fail to bootstrap, and I believe it is because myCustomPalette does not have '1000' defined.

    $mdThemingProvider.definePalette('myCustomPalette', {
      '50': '#f4f5f8',
      '100': '#c5ccdb',
      '200': '#a2adc5',
      '300': '#7687aa',
      '400': '#63769e',
      '500': '#57688c',
      '600': '#4b5a79',
      '700': '#404c66',
      '800': '#343e53',
      '900': '#283040',
      // '1000': '#000',     // uncomment to test
      'A100': '#f4f5f8',
      'A200': '#c5ccdb',
      'A400': '#63769e',
      'A700': '#404c66',
      'contrastDefaultColor': 'light',
      'contrastDarkColors': '50 100 200 300 A100 A200'
    });

    $mdThemingProvider.theme('my-dark-theme')
      .backgroundPalette('myCustomPalette')
      .dark();

tested in 1.1.0-rc1

@EladBezalel EladBezalel added P0: critical Critical issues that must be addressed immediately. and removed P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Mar 20, 2016
EladBezalel added a commit that referenced this issue Mar 21, 2016
- Other palettes doesn't have `1000` therefor when registering a new background palette 1000 couldn't be found

fixes #7600
EladBezalel added a commit that referenced this issue Mar 26, 2016
- Other palettes doesn't have `1000` therefor when registering a new background palette 1000 couldn't be found

fixes #7600
gmoothart pushed a commit to gmoothart/material that referenced this issue Apr 5, 2016
- Other palettes doesn't have `1000` therefor when registering a new background palette 1000 couldn't be found

fixes angular#7600

Closes angular#7686
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0: critical Critical issues that must be addressed immediately. type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants