Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-list: .md-dense - wrong font-size #7552

Closed
ivoviz opened this issue Mar 13, 2016 · 1 comment
Closed

md-list: .md-dense - wrong font-size #7552

ivoviz opened this issue Mar 13, 2016 · 1 comment
Assignees
@crisbeto
Labels
P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review ui: theme
Milestone
1.1.0

Comments

@ivoviz
Copy link
Contributor

ivoviz commented Mar 13, 2016

md-list.md-dense has wrong font-size set. According to the spec it should be 13px, but it actually goes up to ~21px.

Demo here.

Note that the official demo has some additional css added (html: font-size: 62.5%;) which makes it look good there.
@ThomasBurleson ThomasBurleson added P4: minor Minor issues. May not be fixed without community contributions. ui: theme and removed ui: theme labels Mar 14, 2016
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.0 Mar 14, 2016
@elekzalan
Copy link

I had the same problem. By default the <h3> font-size of md-list.md-dense is set to 1.3rem, which is relative to the root element <html>. Thus you have to specify the font size of the root element.

If you set it as html: font-size: 62.5%;, the 1.3rem is going to be like ~13px.

crisbeto added a commit to crisbeto/material that referenced this issue Mar 20, 2016
@crisbeto
fix(list): dense list font size
fb86914 
The dense lists were using rems for the font size, whereas the normal lists were using pixels,
which meant that if the root font size is changed, the two list types would look inconsistent.
This makes them consistent by switching the dense list to using pixels.

Closes angular#7552.
@crisbeto crisbeto mentioned this issue Mar 20, 2016
Closed
@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Mar 20, 2016
gmoothart pushed a commit to gmoothart/material that referenced this issue Apr 5, 2016
@crisbeto @gmoothart
fix(list): dense list font size
d7027af 
The dense lists were using rems for the font size, whereas the normal lists were using pixels,
which meant that if the root font size is changed, the two list types would look inconsistent.
This makes them consistent by switching the dense list to using pixels.

Closes angular#7552. Closes angular#7650
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review ui: theme
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
5 participants
@ThomasBurleson @ivoviz @crisbeto @devversion @elekzalan