This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(demos): codepen demos load svg assets #6727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CodePen demo launches now correctly load the external, svg-assets (and post-load $templateCache) used in some of the md-icon demos. * now defines external module 'material.svgAssetsCache' * now defines extra svgs for 'ic_euro_24px.svg', and 'ic_card_giftcard_24px.svg'
|
@topherfangio - can you review ? |
| function replaceDemoModuleWithCodepenModule(file) { | ||
| var matchAngularModule = /\.module\(('[^']*'|"[^"]*")\s*,(\s*\[([^\]]*)\]\s*\))/ig; | ||
| var modules = "['ngMaterial', 'ngMessages', 'material.svgAssetsCache']"; |
There was a problem hiding this comment.
That's a very good way to fix the asset-cache.
There was a problem hiding this comment.
Thx. It was a brain-teaser at first.
|
@ThomasBurleson - What do you think about a Gulp Task for Generating the Asset Cache (certainly after your PR)? See here for example |
|
@ThomasBurleson LGTM |
|
@devversion - Submit a PR for the Gulp Task to build the asset-cache. Notice that it is now |
This was referenced Jan 19, 2016
devversion
added a commit
to devversion/material
that referenced
this pull request
Jan 19, 2016
- Added Gulp Task for Asset Cache - Updated `CODPEN.MD` (also for angular#6727) - Removed old Asset Cache Build Script - Updated Asset Cache from the Gulp Task
devversion
added a commit
to devversion/material
that referenced
this pull request
Jan 19, 2016
- Added Gulp Task for Asset Cache - Updated `CODPEN.MD` (also for angular#6727) - Removed old Asset Cache Build Script - Updated Asset Cache from the Gulp Task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CodePen demo launches now correctly load the external, svg-assets (and post-load $templateCache) used in some of the md-icon demos.