Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

codepen demos not loading svg icons #6343

Closed
epelc opened this issue Dec 16, 2015 · 3 comments
Closed

codepen demos not loading svg icons #6343

epelc opened this issue Dec 16, 2015 · 3 comments
Labels
P3: important Important issues that really should be fixed when possible. type: demos

Comments

@epelc
Copy link
Contributor

epelc commented Dec 16, 2015

In 1.0.0 the demo's icons aren't loading correctly.

example speeddial demo http://codepen.io/anon/pen/obbPOE

The menu bar demo http://codepen.io/anon/pen/BjjOEE

I'm guessing it's all the demos using svg icons? As the icon demo which uses font icons works fine.
http://codepen.io/anon/pen/yeexWe

I also think it's specific to the demo codepen setup as my app's custom icons loaded via an svg icon set work fine in 1.0.0

@epelc epelc changed the title codepen demos not loading icons codepen demos not loading svg icons Dec 16, 2015
@topherfangio
Copy link
Contributor

This is likely due to commit 86ec22a where we fixed the Codepens not having the proper dependencies.

Interestingly, if we change it to

  angular.module('MyApp')

it seems to work just fine. This is probably because of our assets cache that we use in the Codepen demos (https://s3-us-west-2.amazonaws.com/s.cdpn.io/t-114/assets-cache.js) which declares the module and dependencies for 'MyApp' already.

@ThomasBurleson Perhaps we could declare the assets cache as a separate service which gets injected as a dependency into our demos?

devversion added a commit to devversion/material that referenced this issue Jan 3, 2016
… asset cache.

*Features*
- Fix Asset Cache in Codepen Demos
- Gulp Task to Update Asset Cache automatically (only manually - otherwise `gulp docs` will run too long)

Fixes angular#6343
devversion added a commit to devversion/material that referenced this issue Jan 5, 2016
… asset cache.

*Features*
- Fix Asset Cache in Codepen Demos
- Gulp Task to Update Asset Cache automatically (only manually - otherwise
  `gulp docs` will run too long).

Fixes angular#6343
@ThomasBurleson ThomasBurleson added P3: important Important issues that really should be fixed when possible. type: demos labels Jan 14, 2016
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jan 14, 2016
@devversion
Copy link
Member

That's fixed in #6727 by @ThomasBurleson and is already merged into master in d860274.

@topherfangio
Copy link
Contributor

@devversion Thanks for the update!

@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3: important Important issues that really should be fixed when possible. type: demos
Projects
None yet
Development

No branches or pull requests

6 participants