Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Dialog: Document targetEvent #5219

Closed
epelc opened this issue Oct 16, 2015 · 4 comments
Closed

Dialog: Document targetEvent #5219

epelc opened this issue Oct 16, 2015 · 4 comments
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review type: docs
Milestone

Comments

@epelc
Copy link
Contributor

epelc commented Oct 16, 2015

There should be a function on $mdDialog.confirm() to let you set the targetEvent field.

https://material.angularjs.org/latest/api/service/$mdDialog

@ThomasBurleson ThomasBurleson added this to the 0.12 milestone Oct 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.13, 0.12 Oct 16, 2015
@EladBezalel
Copy link
Member

@epelc there's targetEvent field, as i understand this issue is about lacking documentation and not a bug, am i right?

@epelc
Copy link
Contributor Author

epelc commented Oct 17, 2015

There should be a helper function to set it. So you do not need to create a variable first.

I haven't checked the source but there's no docs for a function to set the targetEvent field.

@EladBezalel
Copy link
Member

As you can easily see in the Dialog Demo (if you open to see the code in the first demo) there is a helper function.

I will document it.

@epelc
Copy link
Contributor Author

epelc commented Oct 17, 2015

Ah I just overlooked that sorry.

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@EladBezalel EladBezalel modified the milestones: 1.0-rc4, 1.0-rc3 Nov 3, 2015
@EladBezalel EladBezalel changed the title mdDialog: confirm/alert do not let you set targetEvent Dialog: Document targetEvent Nov 8, 2015
@EladBezalel EladBezalel modified the milestones: 1.0-rc5, 1.0-rc4 Nov 9, 2015
@EladBezalel EladBezalel modified the milestones: 1.0-rc6, 1.0-rc5 Nov 20, 2015
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Nov 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants