Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdFabSpeedDial: add support for data- and x-prefixes when using ng-repeat #3632

Closed
Frank3K opened this issue Jul 7, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@Frank3K
Copy link
Contributor

Frank3K commented Jul 7, 2015

On the current master (e6c757c) the md-fab-speed-dial is missing support for the data- and x- prefixes for ng-repeat. The directive does work, however the animations are incorrect: the animation for a 'down'-speed-dial goes both down and up (i.e. it is shown above the fab-trigger).

Demo (regular demo with data- added): http://codepen.io/anon/pen/xGWabe

I think the issue comes from the following part of the code:

        if (children.attr('ng-repeat')) {
          children.addClass('md-fab-action-item');
        } else {
          // After setting up the listeners, wrap every child in a new div and add a class that we can
          // scale/fling independently
          children.wrap('<div class="md-fab-action-item">');
        }
@topherfangio topherfangio self-assigned this Jul 7, 2015
@topherfangio topherfangio added this to the 0.11.0 milestone Jul 7, 2015
@topherfangio
Copy link
Contributor

Indeed, thanks for catching this.

@topherfangio topherfangio added needs: work in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Jul 12, 2015
topherfangio added a commit that referenced this issue Jul 12, 2015
 * support data-ng-repeat and x-ng-repeat

closes #3632
topherfangio added a commit that referenced this issue Jul 12, 2015
 * support data-ng-repeat and x-ng-repeat
 * change height from `initial` to `auto` to fix issue in Chrome

closes #3632, closes #3370
@ThomasBurleson ThomasBurleson modified the milestones: 0.11.0, REVISIT Jul 31, 2015
@ThomasBurleson ThomasBurleson added needs: review This PR is waiting on review from the team and removed needs: review This PR is waiting on review from the team labels Jul 31, 2015
topherfangio added a commit that referenced this issue Aug 3, 2015
 * support data-ng-repeat and x-ng-repeat
 * change height from `initial` to `auto` to fix issue in Chrome
 * rename helper function in tests
 * fix fabActions and fabToolbar comments

closes #3632, closes #3370
@topherfangio topherfangio modified the milestones: 0.11.0, REVISIT Aug 3, 2015
@topherfangio
Copy link
Contributor

Still working on this, should have code merged this week.

@topherfangio topherfangio removed the needs: review This PR is waiting on review from the team label Aug 3, 2015
topherfangio added a commit that referenced this issue Aug 3, 2015
 * support data-ng-repeat and x-ng-repeat
 * change height from `initial` to `auto` to fix issue in Chrome
 * rename helper function in tests
 * fix fabActions and fabToolbar comments

closes #3632, closes #3370, closes #3796
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
 * support data-ng-repeat and x-ng-repeat
 * change height from `initial` to `auto` to fix issue in Chrome
 * rename helper function in tests
 * fix fabActions and fabToolbar comments

closes angular#3632, closes angular#3370, closes angular#3796. closes angular#4006.
@ThomasBurleson ThomasBurleson removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants