This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
md-fab-toolbar assumes a md-icon is inside the trigger button. #3223
Comments
|
Thanks for the comment! I'll take a look and get this fixed. |
topherfangio
added a commit
that referenced
this issue
Jun 28, 2015
the component previously assumed the user would have an icon inside the trigger and was throwing an error upon animation which caused the entire component to break closes #3223
topherfangio
added a commit
that referenced
this issue
Jun 28, 2015
the component previously assumed the user would have an icon inside the trigger and was throwing an error upon animation which caused the entire component to break also fix a potential issue with the animation not properly firing the `done()` callback when finished closes #3223
topherfangio
added a commit
that referenced
this issue
Jul 5, 2015
the component previously assumed the user would have an icon inside the trigger and was throwing an error upon animation which caused the entire component to break also fix a potential issue with the animation not properly firing the `done()` callback when finished closes #3223
topherfangio
added a commit
that referenced
this issue
Jul 5, 2015
the component previously assumed the user would have an icon inside the trigger and was throwing an error upon animation which caused the entire component to break also fix a potential issue with the animation not properly firing the `done()` callback when finished closes #3223
topherfangio
added a commit
that referenced
this issue
Jul 6, 2015
the component previously assumed the user would have an icon inside the trigger and was throwing an error upon animation which caused the entire component to break also fix a potential issue with the animation not properly firing the `done()` callback when finished closes #3223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
I played with the new
<md-fab-toolbar>directive. I don't have an icon in my trigger button (only text) and I encountered this problem :The result of
var iconElement = el.querySelector('md-fab-trigger button md-icon');is null. It triggers an exception in the runAnimation function (cannot read property style of null).Otherwise it looks very good :-)
The text was updated successfully, but these errors were encountered: