Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Toolbar should resize height based on media #2047

Closed
asans opened this issue Mar 27, 2015 · 3 comments
Closed

Toolbar should resize height based on media #2047

asans opened this issue Mar 27, 2015 · 3 comments
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review type: enhancement
Milestone

Comments

@asans
Copy link

asans commented Mar 27, 2015

According to Material Designs Guides for Layout Structure of App Bar:

Metrics

Default height:
Mobile Landscape: 48dp
Mobile Portrait: 56dp
Tablet/Desktop: 64dp

For extended app bars, the height is equal to the default height plus content increment(s).

Under desktop resolution, the toolbar is 64dp. However, as I resize to smaller resolution, the toolbar height does not change and continues to stay at 64dp when it should resize appropriately to the correct height.

@marcysutton
Copy link
Contributor

@ThomasBurleson the new Typography styles use rem units as "scaleable pixels" based off the body but we don't actually change the font size when the resolution changes. If we did, other rem units such as heights and margins could automatically change. Something to think about when reviewing this issue. It would be an easy thing to do now that we're using rem.

@asans
Copy link
Author

asans commented May 13, 2015

In addition to the toolbar resizing, the app bar buttons to the right should also have the margins/padding adjusted.

For smaller media screens:

layout_structure_appbar_metrics1

For larger media screens:

layout_structure_appbar_metrics7

NOTE: The spacing on the right is calculated from the right edge of the toolbar to the button image's right edge (without the padding), not to the edge of the 48x48 button size with padding.

Spacing between the buttons are also much smaller. It looks to be 4px or less, not the typical 8px spacing between buttons.

@ThomasBurleson ThomasBurleson modified the milestones: 0.10.0, 0.11.0 Jun 16, 2015
@Davidriquelme
Copy link

are we expecting this in 1.0 ?

topherfangio added a commit that referenced this issue Aug 14, 2015
On smaller screens, the toolbar now properly changes sizes according
to the Material Specs.

closes #2047
topherfangio added a commit that referenced this issue Aug 14, 2015
On smaller screens, the toolbar now properly changes sizes according
to the Material Specs.

closes #2047
@topherfangio topherfangio added the pr: merge ready This PR is ready for a caretaker to review label Aug 15, 2015
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
On smaller screens, the toolbar now properly changes sizes according
to the Material Specs.

closes angular#2047

closes angular#4161
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants