Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Add GitHub link #77

Merged
merged 8 commits into from
Mar 13, 2017
Merged

Conversation

jshbrntt
Copy link

@jshbrntt jshbrntt commented Jan 5, 2017

I was frustrated that I could not easily navigate to the GitHub repository from the docs site so I've added the link to the navbar.

screenshot

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jshbrntt
Copy link
Author

jshbrntt commented Jan 5, 2017

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 5, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @synthecypher, sorry for the delay. Just a few comments on the PR.


.pull-left {
float: left;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using float, these should use flex stylings to put things on the left/right.

float: right;
}

.pull-left {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the css classes should be prefixed with docs-

<img class="docs-github-logo"
src="../../../assets/img/homepage/github-circle-white-transparent.svg"
alt="GitHub">
<span>GitHub</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the span necessary?

@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="20px" height="20px" viewBox="0 0 20 20" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<!-- Generator: Sketch 41.2 (35397) - http://www.bohemiancoding.com/sketch -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this SVG needs to be optimized (with a tool like svgo)

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@jshbrntt jshbrntt force-pushed the feature/add-github-link branch from 8bf9846 to 94e3db9 Compare March 13, 2017 17:04
@jshbrntt jshbrntt force-pushed the feature/add-github-link branch from 129db06 to 4206ed6 Compare March 13, 2017 17:35
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@jshbrntt
Copy link
Author

@jelbourn Should have covered all your comments, please take another look.

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit 686b5dd into angular:master Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants