-
Notifications
You must be signed in to change notification settings - Fork 401
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @synthecypher, sorry for the delay. Just a few comments on the PR.
src/app/material-docs-app.scss
Outdated
|
||
.pull-left { | ||
float: left; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than using float, these should use flex stylings to put things on the left/right.
src/app/material-docs-app.scss
Outdated
float: right; | ||
} | ||
|
||
.pull-left { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the css classes should be prefixed with docs-
src/app/shared/navbar/navbar.html
Outdated
<img class="docs-github-logo" | ||
src="../../../assets/img/homepage/github-circle-white-transparent.svg" | ||
alt="GitHub"> | ||
<span>GitHub</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the span
necessary?
@@ -0,0 +1,12 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<svg width="20px" height="20px" viewBox="0 0 20 20" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |||
<!-- Generator: Sketch 41.2 (35397) - http://www.bohemiancoding.com/sketch --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this SVG needs to be optimized (with a tool like svgo)
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
8bf9846
to
94e3db9
Compare
129db06
to
4206ed6
Compare
CLAs look good, thanks! |
@jelbourn Should have covered all your comments, please take another look. |
LGTM |
I was frustrated that I could not easily navigate to the GitHub repository from the docs site so I've added the link to the navbar.