Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Make theme swapping css-based and clean up tests #188

Merged
merged 15 commits into from
Jun 19, 2017
Merged

Make theme swapping css-based and clean up tests #188

merged 15 commits into from
Jun 19, 2017

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Jun 18, 2017 •
edited
Loading

The commits for this PR should be preserved for merging.

Changes:

  • Add CSS classes to SVGs so that the colors can be changed via CSS
  • Add mixin for stamping out styles for those SVGs
  • Change the default theme to indigo-pink
  • Create an NgModule per-component
  • Make all tests use one consistent testing module
  • Don't call createComponent synchronously after compileComponents
  • Change ComponentViewer from tab-group to nav-tabs
  • Simplify routes
  • A few misc visual tweaks

@jelbourn jelbourn requested a review from tinayuangao June 18, 2017 01:00
tinayuangao
tinayuangao approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 7b53cfc into angular:master Jun 19, 2017
@Splaktar Splaktar mentioned this pull request Jul 10, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees

@tinayuangao tinayuangao

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @tinayuangao @googlebot