This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Consume pre-built examples from material2 repo #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR: * Deletes src/app/examples * Changes imports to use `@angular/material-examples/` * Updates the `fetch-assets.sh` script to `npm install` the material-examples package from material2-docs-content.
devversion
approved these changes
May 30, 2017
| @@ -62,7 +60,8 @@ describe('ExampleViewer', () => { | |||
| component.example = exampleComponentString; | |||
| fixture.detectChanges(); | |||
| const data = component.exampleData; | |||
| expect(data).toEqual(EXAMPLE_COMPONENTS[exampleComponentString]); | |||
| // TODO(jelbourn): remove `as any` once LiveExample is updated to hve optional members. | |||
|
Updated PR to copy assets for plunker as well |
devversion
approved these changes
May 31, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@angular/material-examples/fetch-assets.shscript tonpm installthematerial-examples package from material2-docs-content.
fetch-assets.shscript to copy example sources from material2-docs-content into assets for plunkers