This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
chore(tests): Add unit tests for each component. #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2017
|
Looks like CI is failing on an scss issue |
riavalon
force-pushed
the
chore-unit-tests
branch
from
0827c7e to
bff567e
Compare
|
I believe the scss issue was due to it building with |
riavalon
force-pushed
the
chore-unit-tests
branch
4 times, most recently
from
466fdf1 to
717a1f3
Compare
jelbourn
reviewed
Apr 8, 2017
package.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| "@angular/core": "^2.4.6", | |||
| "@angular/forms": "^2.4.6", | |||
| "@angular/http": "^2.4.6", | |||
| "@angular/material": "^2.0.0-beta.1", | |||
| "@angular/material": "^2.0.0-beta.2", | |||
There was a problem hiding this comment.
Can revert this line now that we're on beta.3
| fixture.detectChanges(); | ||
| })); | ||
|
|
||
| it('should render four rows of content on the homepage', () => { |
There was a problem hiding this comment.
I don't think we need these homepage tests since it's all just static content.
src/app/shared/footer/footer.spec.ts
Outdated
| .querySelector('.docs-footer-links a'); | ||
| const href = link.getAttribute('href'); | ||
| const text = link.textContent; | ||
| expect(~href.indexOf('angular.io')).toBeTruthy(); |
There was a problem hiding this comment.
Should be able to do
expect(href).toContain('angular.io');
src/app/shared/footer/footer.spec.ts
Outdated
| expect(text).toContain('Learn Angular'); | ||
| }); | ||
|
|
||
| it('should show an angular logo in the footer', () => { |
There was a problem hiding this comment.
I don't think a test for the this is necessary
src/app/shared/navbar/navbar.spec.ts
Outdated
| fixture.detectChanges(); | ||
| })); | ||
|
|
||
| it('should have four main links', () => { |
There was a problem hiding this comment.
I think this test also isn't needed
riavalon
force-pushed
the
chore-unit-tests
branch
6 times, most recently
from
b85ea7a to
616a64d
Compare
riavalon
force-pushed
the
chore-unit-tests
branch
from
616a64d to
48b3094
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.