This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 401
feat: show deprecated related information in material/tooltip
#1274
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import {Component} from '@angular/core'; | ||
import {MatTooltipModule} from '@angular/material/tooltip'; | ||
|
||
/** | ||
* This component is responsible for showing the | ||
* deprecated fields throughout API from material repo, | ||
* | ||
* When deprecated docs content is generated like: | ||
* | ||
* <div class="docs-api-class-deprecated-marker" | ||
* title="Will be removed in v21.0.0 or later"> | ||
* Deprecated | ||
* </div> | ||
* | ||
* It uses `title` attribute to show information regarding | ||
* deprecation and other information regarding deprecation | ||
* isnt shown either. | ||
* | ||
* We are gonna use this component to show deprecation | ||
* information using the `material/tooltip`, the information | ||
* would contain when the field is being deprecated and what | ||
* are the alternatives to it which both are extracted from | ||
* `breaking-change` and `deprecated`. | ||
*/ | ||
@Component({ | ||
selector: 'deprecated-field', | ||
template: `<div class="deprecated-content" | ||
[matTooltip]="message"> | ||
</div>`, | ||
standalone: true, | ||
imports: [MatTooltipModule], | ||
}) | ||
export class DeprecatedFieldComponent { | ||
/** Message regarding the deprecation */ | ||
message = ''; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
$=
needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its shorter for like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. How about adding a small comment illustrating the pattern + using
-deprecated-marker
as suffix test?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good now, lemme know if it needs rewording cause my english isn't so good.