This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 401
bug(components with test harness example): Missing dependencies in StackBlitz examples #997
Labels
Comments
It looks like we need to add material.angular.io/src/app/shared/stack-blitz/stack-blitz-writer.ts Lines 94 to 95 in 95fa5a7
I think that we need to add jasmine-core to this package.json as well.
|
amysorto
added a commit
to amysorto/material.angular.io
that referenced
this issue
May 26, 2021
Splaktar
added a commit
to DevIntent/material.angular.io
that referenced
this issue
Jun 7, 2021
- remove tslint and codelyzer from examples - update jasmine dependencies - remove unused material-module.ts from test assets - add jasmine-core to package.json in stack-blitz-tests/ - disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts` is not compatible Fixes angular#997
It wasn't that easy at all. But I have a fix in PR #1009. |
Splaktar
added a commit
to DevIntent/material.angular.io
that referenced
this issue
Jul 19, 2021
- remove tslint and codelyzer from examples - update jasmine dependencies - remove unused material-module.ts from test assets - add jasmine-core to package.json in stack-blitz-tests/ - disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts` is not compatible Fixes angular#997
crisbeto
pushed a commit
that referenced
this issue
Jul 29, 2021
…les (#1009) - remove tslint and codelyzer from examples - update jasmine dependencies - remove unused material-module.ts from test assets - add jasmine-core to package.json in stack-blitz-tests/ - disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts` is not compatible Fixes #997
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reproduction
This applies for the example that use test harness for all material components (except for ripples).
Steps to reproduce:
Expected Behavior
A working StackBlitz link for these examples. The examples in the documentation site for v11 work as expected (working example for tree component).
Actual Behavior
The StackBlitz link for v12 documentation for test harnesses show an error (failing example for tree component).
The error is the same for all:
Environment
The text was updated successfully, but these errors were encountered: