Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(versions): upgrade dependency-tree to 6.0.0 #584

Closed
wants to merge 1 commit into from
Closed

chore(versions): upgrade dependency-tree to 6.0.0 #584

wants to merge 1 commit into from

Conversation

akkumar
Copy link
Contributor

@akkumar akkumar commented Jan 20, 2018

Address the following warning.

npm WARN [email protected] requires a peer of typescript@~2.0.3 but none is installed. You must install peer dependencies yourself.

by upgrading dependency-tree to 6.0.0 (madge depends on the same. Independently, pr logged with madge as well to avoid explicitly upgrading dependency-tree - pahen/madge#147 ).

@CaerusKaru
Copy link
Member

Since you have a PR open for madge, I see no reason to add an extra dev dependency here, even temporarily. It's only a warning, after all.

@CaerusKaru CaerusKaru closed this Jan 20, 2018
@akkumar akkumar deleted the ts_eslint_parser branch January 22, 2018 09:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants