Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscribing to ObservableMedia doesnt start with value on load of XS mq #388

Closed
tuurbo opened this issue Aug 23, 2017 · 2 comments · Fixed by #396
Closed

subscribing to ObservableMedia doesnt start with value on load of XS mq #388

tuurbo opened this issue Aug 23, 2017 · 2 comments · Fixed by #396
Labels
bug has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Milestone
v2.0.1-beta.10

Comments

@tuurbo
Copy link

tuurbo commented Aug 23, 2017 •
edited by ThomasBurleson
Loading

Open the example below with a XS mobile size screen and ObservableMedia doesn't fire on page load, but it seems to work fine for all other media query sizes.

screen shot 2017-08-28 at 5 38 13 pm

https://angular-wfwpzp.stackblitz.io/

source:
https://stackblitz.com/edit/angular-wfwpzp?file=app%2Fapp.component.ts
@ThomasBurleson ThomasBurleson added bug P1 Urgent issue that should be resolved before the next re-lease labels Aug 28, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.10 milestone Aug 28, 2017
ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
4749911 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
@ThomasBurleson ThomasBurleson mentioned this issue Aug 29, 2017
Closed
@ThomasBurleson ThomasBurleson added the has pr A PR has been created to address this issue label Aug 29, 2017
@ThomasBurleson
Copy link
Contributor

See working Plunkr

screen shot 2017-08-28 at 7 48 52 pm

ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
d8c6d5b 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
@ThomasBurleson ThomasBurleson mentioned this issue Aug 29, 2017
Merged
ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
12eaf0d 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
76a773a 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
6c2b448 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
7b64345 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
ThomasBurleson added a commit that referenced this issue Aug 29, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
1a4ac6c 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
ThomasBurleson added a commit that referenced this issue Aug 31, 2017
@ThomasBurleson
fix(ObservableMedia): properly announce 'xs' activation at startup
eeea8fb 
MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
tinayuangao pushed a commit that referenced this issue Sep 7, 2017
@ThomasBurleson @tinayuangao
fix(ObservableMedia): properly announce 'xs' activation at startup (#396
66f3717 
)

MatchMedia was not properly announcing XS activations for applications with startup viewports < 600px.
Improve the specificity of the 'xs' media query enables proper MatchMedia notifications at startup.

Fixes #388.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Milestone
v2.0.1-beta.10
2 participants
@ThomasBurleson @tuurbo