Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline-flex doesn't seem to apply when using fxLayoutAlign #1009

Closed
captaincaius opened this issue Jan 25, 2019 · 3 comments · Fixed by #1036
Closed

inline-flex doesn't seem to apply when using fxLayoutAlign #1009

captaincaius opened this issue Jan 25, 2019 · 3 comments · Fixed by #1036
Assignees
Labels
bug has pr A PR has been created to address this issue P3 Important issue that needs to be resolved
Milestone

Comments

@captaincaius
Copy link

captaincaius commented Jan 25, 2019

Bug Report

I tried to follow the examples in the tests in PR 539 to get inline-flex applied.

screen shot 2019-01-25 at 5 47 14 pm

What is the expected behavior?

When applying fxLayout="row inline" with fxLayoutAlign="fill center", the containing element should have inline-flex applied instead of flex.

What is the current behavior?

without fxLayoutAlign it applies properly, but with fxLayoutAlign for some reason it doesn't.

What are the steps to reproduce?

Providing a StackBlitz (or similar) is the best way to get the team to see your issue.

What is the use-case or motivation for changing an existing behavior?

mat-button's wrap whatever you put inside it by span, so trying to use fxLayout within the body of a mat-button doesn't work right.

of course, my example shows that the problem isn't related to material and it shows even without it ;)

@CaerusKaru CaerusKaru added bug in-progress P3 Important issue that needs to be resolved labels Jan 25, 2019
@CaerusKaru CaerusKaru self-assigned this Jan 25, 2019
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.24 milestone Jan 25, 2019
@CaerusKaru
Copy link
Member

I prayed no one would actually encounter this, because it's really, really annoying. But it's a bug nonetheless, so we're on it!

@captaincaius
Copy link
Author

:D sorry to ruin your prayers! If it makes you feel better, mine rarely get answered either ;).

Thanks for the awesome quick reply!

@CaerusKaru CaerusKaru added has pr A PR has been created to address this issue and removed in-progress labels Mar 16, 2019
CaerusKaru added a commit that referenced this issue Mar 16, 2019
Before this commit, `fxLayoutAlign` only respected the sibling
`fxLayout` direction (including `reverse` attribute), but not
the `inline` attribute. This commit corrects that behavior

Fixes #1009
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug has pr A PR has been created to address this issue P3 Important issue that needs to be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants