This repository has been archived by the owner on Apr 9, 2022. It is now read-only.
feat(@schematics/angular): use application name as title in AppComponent #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
approved these changes
May 16, 2018
|
Doesn't this break the default e2e test? We just fixed it so it now uses the prefix 😢 https://github.com/angular/devkit/blob/master/packages/schematics/angular/e2e/files/src/app.e2e-spec.ts |
|
Good point @cexbrayat - let's get it fixed in the e2e test! Happy to send in a PR for that |
cexbrayat
added a commit
to cexbrayat/devkit
that referenced
this pull request
May 17, 2018
PR angular#906 updated the app schematics to display the name of the app in the title, so the e2e test has to be fixed. The prefix is now useless (it was introduced by angular#720 to fix the e2e test when it was using prefix), and has been removed.
cexbrayat
added a commit
to cexbrayat/devkit
that referenced
this pull request
May 17, 2018
PR angular#906 updated the app schematics to display the name of the app in the title, so the e2e test has to be fixed. The prefix is now useless (it was introduced by angular#720 to fix the e2e test when it was using prefix), and has been removed.
cexbrayat
added a commit
to cexbrayat/devkit
that referenced
this pull request
May 17, 2018
PR angular#906 updated the app schematics to display the name of the app in the title, so the e2e test has to be fixed. The prefix is now useless (it was introduced by angular#720 to fix the e2e test when it was using prefix), and has been removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current schematic creates a new AppComponent with the value of the title property set to
app(the value ofprefixin the schematic).With the support of multiple projects it makes more sense to use the app name, so if you run
ng generate application adminthe initial page will reflect that:Welcome to admin.