This repository has been archived by the owner on Apr 9, 2022. It is now read-only.
fix(@schematics/angular): fix e2e schematic to expect welcome message with prefix #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with prefix The "application" schematic generates the welcome message in AppComponent with the app prefix. The "e2e" schematic should include the prefix in the spec file accordingly.
|
🙁 Duplicate of #720 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "application" schematic generates the welcome message in AppComponent with the app prefix.
The "e2e" schematic did not include the prefix in the spec file accordingly.
This PR includes the app prefix in the welcome message spec.
Thanks for reviewing this!