Create summary column #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the label model to include the font color that is of good contrast for the labels background color.
Create a summary column in the prs application for displaying information about a pull request.
josephperrott
added
action: merge
devversion
approved these changes
Apr 17, 2022
apps/shared/models/pull-request.ts
Outdated
| this.milestone = data.milestone as any; | ||
| this.assignees = data.assignees as any; | ||
| this.commit = data.commit; | ||
| User.getByReference(data.user).then((u) => (this.user = u)); |
There was a problem hiding this comment.
Do we need to await this? Otherwise user might be undefined shortly right?
There was a problem hiding this comment.
Tsetse complains about this. I believe it would be good supporting async population of a model. We control the instantiation anyway, so that would improve this even further.
There was a problem hiding this comment.
I awaited it and will make the instantiation async in a follow up.
josephperrott
force-pushed
the
create-summary
branch
from
055a4d7 to
ff54b88
Compare
josephperrott
force-pushed
the
create-summary
branch
from
ff54b88 to
33e5589
Compare
devversion
approved these changes
Apr 17, 2022
|
This PR was merged into the repository by commit 8a7e038. |
devversion
pushed a commit
that referenced
this pull request
Apr 17, 2022
Create a summary column in the prs application for displaying information about a pull request. PR Close #520
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See invididual commits.