Create account menu and login page #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An accounnt menu component which can be used to manage login state as well as display the logged in user and their account linking status.
Create the login page for the prs application.
josephperrott
added
action: merge
devversion
approved these changes
Apr 7, 2022
|
|
||
| constructor(private auth: Auth) { | ||
| this.auth.onAuthStateChanged((user) => { | ||
| this.avatarUrl = user?.photoURL || DEFAULT_AVATAR_URL; |
There was a problem hiding this comment.
For more explicitness we could use nullish coalescing, same below.
Suggested change
| this.avatarUrl = user?.photoURL || DEFAULT_AVATAR_URL; | |
| this.avatarUrl = user?.photoURL ?? DEFAULT_AVATAR_URL; |
There was a problem hiding this comment.
We actually don't want nullish coalescing in this case because if the photoURL we get is '' we want to use the default one instead.
josephperrott
force-pushed
the
login-setup
branch
from
3ab7322 to
dc253ff
Compare
josephperrott
removed
the
action: review
|
This PR was merged into the repository by commit 50857c6. |
josephperrott
added a commit
that referenced
this pull request
Apr 7, 2022
Create the login page for the prs application. PR Close #502
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.