fix(ng-dev/release): only match on a single character prefixed version for snapshotting #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for snapshotting Previously we matched on all characters before our semver matching in the glob used for finding the latest version for the branch we are on. However when the branch contains something like zonejs-1.2.3, the * matcher would capture it, leading to an unexpected syntax. Instead we should allow for only a single letter, typically 'v', to prefix our version tags.
devversion
reviewed
Mar 4, 2022
devversion
approved these changes
Mar 4, 2022
devversion
added
the
action: cleanup
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Mar 4, 2022
… tag Local patch ahead of landing of angular/dev-infra#449
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Mar 4, 2022
… tag Local patch ahead of landing of angular/dev-infra#449
… version for snapshotting
josephperrott
removed
the
action: cleanup
devversion
approved these changes
Mar 4, 2022
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Mar 4, 2022
… tag Local patch ahead of landing of angular/dev-infra#449
josephperrott
added a commit
to josephperrott/angular
that referenced
this pull request
Mar 4, 2022
… tag Local patch ahead of landing of angular/dev-infra#449
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Mar 4, 2022
… tag (#45269) Local patch ahead of landing of angular/dev-infra#449 PR Close #45269
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Mar 4, 2022
… tag (#45269) Local patch ahead of landing of angular/dev-infra#449 PR Close #45269
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we matched on all characters before our semver matching in the glob used for finding
the latest version for the branch we are on. However when the branch contains something like
zonejs-1.2.3, the*matcher would capture it, leading to an unexpected syntax. Instead we shouldallow for only a single letter, typically
v, to prefix our version tags.cc: @AndrewKushnir