Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-dev): allow deprecations in PRs during feature freeze #256

Conversation

josephperrott
Copy link
Member

Currently our tooling does not distinguish between when RC is occurring and when feature freeze is occurring.
Since they are treated as the same state, we are unable to allow deprecations messages on feature freeze without
allowing it during RC periods. By creating this distinction we can properly handle this case.

@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 8, 2021
@google-cla google-cla bot added the cla: yes label Oct 8, 2021
@josephperrott josephperrott force-pushed the deprecations-during-feature-freeze branch 2 times, most recently from 7504e2c to c60d04a Compare October 8, 2021 00:20
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 🎉

I'm slightly unhappy that the creation of the active release trains is not as obvious as before. i.e. with the object it was clear what ReleaseTrain goes into next for example, while now we have positional arguments.

@josephperrott
Copy link
Member Author

@devversion Yeah, I don't love that its positional, I thought about potentially having it be the object from before that was provided as the argument. But wasn't sure if that would end up better.

So we could have

export class ActiveReleaseTrains {
  /** Release-train currently in the "release-candidate" or "feature-freeze" phase. */
  readonly releaseCandidate: ReleaseTrain | null = this.trains.releaseCandidate;
  /** Release-train in the `next` phase. */
  readonly next: ReleaseTrain = this.trains.next;
  /** Release-train currently in the "latest" phase. */
  readonly latest: ReleaseTrain = this.trains.latest

  constructor(private trains: {
    releaseCandidate: ReleaseTrain | null,
    next: ReleaseTrain,
    latest: ReleaseTrain,
  }) {}
...

@josephperrott josephperrott force-pushed the deprecations-during-feature-freeze branch from c60d04a to d3d333e Compare October 8, 2021 17:04
Currently our tooling does not distinguish between when RC is occurring and when feature freeze is occurring.
Since they are treated as the same state, we are unable to allow deprecations messages on feature freeze without
allowing it during RC periods.  By creating this distinction we can properly handle this case.
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Oct 8, 2021
@josephperrott josephperrott force-pushed the deprecations-during-feature-freeze branch from d3d333e to 8af3e39 Compare October 8, 2021 17:08
@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit cce6d07.

@josephperrott josephperrott deleted the deprecations-during-feature-freeze branch October 8, 2021 17:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants