-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ng-dev): allow deprecations in PRs during feature freeze #256
fix(ng-dev): allow deprecations in PRs during feature freeze #256
Conversation
7504e2c
to
c60d04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome 🎉
I'm slightly unhappy that the creation of the active release trains is not as obvious as before. i.e. with the object it was clear what ReleaseTrain
goes into next
for example, while now we have positional arguments.
@devversion Yeah, I don't love that its positional, I thought about potentially having it be the object from before that was provided as the argument. But wasn't sure if that would end up better. So we could have export class ActiveReleaseTrains {
/** Release-train currently in the "release-candidate" or "feature-freeze" phase. */
readonly releaseCandidate: ReleaseTrain | null = this.trains.releaseCandidate;
/** Release-train in the `next` phase. */
readonly next: ReleaseTrain = this.trains.next;
/** Release-train currently in the "latest" phase. */
readonly latest: ReleaseTrain = this.trains.latest
constructor(private trains: {
releaseCandidate: ReleaseTrain | null,
next: ReleaseTrain,
latest: ReleaseTrain,
}) {}
... |
c60d04a
to
d3d333e
Compare
Currently our tooling does not distinguish between when RC is occurring and when feature freeze is occurring. Since they are treated as the same state, we are unable to allow deprecations messages on feature freeze without allowing it during RC periods. By creating this distinction we can properly handle this case.
d3d333e
to
8af3e39
Compare
This PR was merged into the repository by commit cce6d07. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently our tooling does not distinguish between when RC is occurring and when feature freeze is occurring.
Since they are treated as the same state, we are unable to allow deprecations messages on feature freeze without
allowing it during RC periods. By creating this distinction we can properly handle this case.