fix(ng-dev): merge tool accidentally performing unauthenticated Github requests #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge tool accidentally performs unauthenticated Github API
requests. This started happening when we refactored some things
in the merge tool.
We should not rely on default values for parameters as explicit
parameters encourage thinking about passing the potentially needed
/already-existing values (like for the authenctiated git client).
This commit changes this in all places of the merge tool and
release tool in order to ensure we always use the correct
instance of the Git client (as initially configured).
Note: We could theoretically have a method that returns a git
client singleton, prioritizing the authenticated one. Though I
personally still believe that being explicit is better and encouraging
thinking of function consumers.