Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-dev/pr): Move the cleanup of the merge attempt to the finally block #216

Closed

Conversation

josephperrott
Copy link
Member

Move the cleanup of the merge attempt to the finally block to ensure that the cleanup
of the generated branches occurs regardless of the success of the merge attempt.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 13, 2021
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small comment

ng-dev/pr/merge/task.ts Outdated Show resolved Hide resolved
…block

Move the cleanup of the merge attempt to the finally block to ensure that the cleanup
of the generated branches occurs regardless of the success of the merge attempt.
@josephperrott josephperrott force-pushed the cleanup-on-merge-failures branch from 8713829 to eefc302 Compare September 13, 2021 22:17
@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 13, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2021
@josephperrott josephperrott deleted the cleanup-on-merge-failures branch August 10, 2022 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants