feat(bazel): support for terser v5 and 2020 in rollup_bundle rule #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports for terser v5 in the `ng_rollup_bundle` rule. currently terser fails because there is a conflicting `--beautify` CLI flag set by `@bazel/terser` and the `output` option. Instead, the new `format` name should be used: ``` ERROR: Please only specify either output or format option, preferrably format. ```
Make output flavor more generic in comment
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports for terser v5 in the
ng_rollup_bundlerule. currentlyterser fails because there is a conflicting
--beautifyCLI flagset by
@bazel/terserand theoutputoption we manually control.Instead of
output, the new non-conflictingformatname should be used: