fix(ng-dev/release): fetch release notes compare tag and store it locally #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
commented
Sep 8, 2021
ng-dev/release/publish/actions.ts
Outdated
| // We forcibly override existing local tags that are named similar as we will fetch | ||
| // the correct tag for release notes comparison from the upstream remote. | ||
| this.git.run(['fetch', '--force', this.git.getRepoGitUrl(), | ||
| `refs/tags/${releaseNotesCompareTag}:refs/tags/${releaseNotesCompareTag}`]); |
There was a problem hiding this comment.
Note that tag <name> would also work as refspec but I think it's better being explicit here. Quote from Git docs:
tag means the same as refs/tags/:refs/tags/; it requests fetching everything up to the given tag.
…ally The release notes compare tag might not exist locally if the local repository has not been synced with upstream. We fetch the release notes compare tag in order to be able to build the changelog. Our current fetch logic incorrectly stores the tag reference in `FETCH_HEAD`, while we want it to be stored locally. This commit fixes that.
devversion
force-pushed
the
fix/release-fetch-local-tag-properly
branch
2 times, most recently
from
4c8f5ee to
5201add
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release notes compare tag might not exist locally if the local
repository has not been synced with upstream. We fetch the release
notes compare tag in order to be able to build the changelog. Our
current fetch logic incorrectly stores the tag reference in
FETCH_HEAD, while we want it to be stored locally. This commitfixes that.