Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use authenticated git url for pushing updated changelog entries #199

Closed
wants to merge 2 commits into from

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Sep 1, 2021

See individual commits

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 1, 2021
@google-cla google-cla bot added the cla: yes label Sep 1, 2021
@josephperrott josephperrott changed the title Fix changelog ci: use authenticated git url for pushing updated changelog entries Sep 1, 2021
@josephperrott josephperrott force-pushed the fix-changelog branch 5 times, most recently from 8b644c6 to fc327f9 Compare September 1, 2021 23:49
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. just a few nit questions for clarity/readability.

.github/workflows/update-changelog.yml Show resolved Hide resolved
ng-dev/utils/git/github-urls.ts Show resolved Hide resolved
tools/local-actions/changelog/lib/main.ts Outdated Show resolved Hide resolved
…icated git URLs

Github requires that both the username and password values are provided when setting a
remote as an authenticated URL.

Previously we did not see any issues with how we set authentication for because all usages of our tooling
was performed in an environment that already had authentication set up, so if the authentication didn't
work via the remote url, git just used the git cached credentials.
@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 2, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only the changelog action main needs to be re-updated.

//tools/local-actions/changelog:main                                     FAILED in 2.2s

Use the authenticated git url for pushing updated changelog entries, also sets persist_credentials
to false for the action/checkout@2 usage in the workflow.

Additionally, because the authentication is being provided via the git url [email protected]
can be used as the email once again.
josephperrott added a commit that referenced this pull request Sep 2, 2021
…199)

Use the authenticated git url for pushing updated changelog entries, also sets persist_credentials
to false for the action/checkout@2 usage in the workflow.

Additionally, because the authentication is being provided via the git url [email protected]
can be used as the email once again.

PR Close #199
@josephperrott josephperrott deleted the fix-changelog branch September 2, 2021 19:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants