-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use authenticated git url for pushing updated changelog entries #199
Conversation
8b644c6
to
fc327f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. just a few nit questions for clarity/readability.
fc327f9
to
1447de8
Compare
…icated git URLs Github requires that both the username and password values are provided when setting a remote as an authenticated URL. Previously we did not see any issues with how we set authentication for because all usages of our tooling was performed in an environment that already had authentication set up, so if the authentication didn't work via the remote url, git just used the git cached credentials.
1447de8
to
58ac307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only the changelog action main needs to be re-updated.
//tools/local-actions/changelog:main FAILED in 2.2s
Use the authenticated git url for pushing updated changelog entries, also sets persist_credentials to false for the action/checkout@2 usage in the workflow. Additionally, because the authentication is being provided via the git url [email protected] can be used as the email once again.
58ac307
to
da43b2e
Compare
…199) Use the authenticated git url for pushing updated changelog entries, also sets persist_credentials to false for the action/checkout@2 usage in the workflow. Additionally, because the authentication is being provided via the git url [email protected] can be used as the email once again. PR Close #199
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
See individual commits