fix(github-actions): use find instead of filter to allow a boolean ch…

…eck for non-approved reviews
angular · May 12, 2022 · c9f0e5d · c9f0e5d
1 parent 438ba57
commit c9f0e5d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/github-actions/post-approval-changes/lib/main.ts b/github-actions/post-approval-changes/lib/main.ts
@@ -83,7 +83,7 @@ async function run(): Promise<void> {
     return;
   }
 
-  if (reviews.filter((review) => review.state !== 'APPROVED')) {
+  if (reviews.find((review) => review.state !== 'APPROVED')) {
     core.info('Skipping check as there are still non-approved review states.');
     return;
   }

diff --git a/github-actions/post-approval-changes/main.js b/github-actions/post-approval-changes/main.js
@@ -15303,7 +15303,7 @@ async function run() {
     core.info("Skipping check as their are no reviews on the pull request.");
     return;
   }
-  if (reviews.filter((review) => review.state !== "APPROVED")) {
+  if (reviews.find((review) => review.state !== "APPROVED")) {
     core.info("Skipping check as there are still non-approved review states.");
     return;
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -83,7 +83,7 @@ async function run(): Promise<void> { @@
         return;
       }
-      if (reviews.filter((review) => review.state !== 'APPROVED')) {
+      if (reviews.find((review) => review.state !== 'APPROVED')) {
         core.info('Skipping check as there are still non-approved review states.');
         return;
       }
@@ Expand Down @@