Skip to content

Commit

Permalink
fix(bazel/karma): web test arguments not passed through
Browse files Browse the repository at this point in the history
Fixes that the webtest arguments are not passed through to the
debug target. Also wires up the rule in our own tests as planned
initially (now that the test is merged)
  • Loading branch information
devversion committed Feb 14, 2022
1 parent 9593bb1 commit 5b35e20
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bazel/browsers/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite")
load("//bazel/karma:index.bzl", "karma_web_test_suite")
load("//bazel/spec-bundling:index.bzl", "spec_bundle")

karma_web_test_suite(
Expand Down
2 changes: 1 addition & 1 deletion bazel/karma/index.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def karma_web_test_suite(name, **kwargs):

# Custom standalone web test that can be run to test against any
# browser that is manually connected to.
_karma_debug_browsers_target(name = "%s_debug" % name)
_karma_debug_browsers_target(name = "%s_debug" % name, **web_test_args)

# Default test suite with all configured browsers.
_karma_web_test_suite(name = name, **kwargs)

0 comments on commit 5b35e20

Please sign in to comment.